From 966a80c690410384cea6fcc8840c70d8b7d9956e Mon Sep 17 00:00:00 2001 From: Sjoerd de Vries Date: Sat, 5 Sep 2026 17:44:29 +0200 Subject: [PATCH] fix: don't let a failed browser launch override a successful runCheck result Guard the finally block's re-await of browserPromise so a rejected launch (e.g. Playwright can't start Chromium) doesn't rethrow out of finally and override the try block's already-successful return value. Co-Authored-By: Claude Sonnet 5 Claude-Session: https://claude.ai/code/session_013gwc3aCiyQxmCWQke8RvEz --- server.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/server.js b/server.js index f8cd297..c75d544 100644 --- a/server.js +++ b/server.js @@ -67,10 +67,12 @@ async function runCheck() { return results; } finally { if (browserPromise) { - const browser = await browserPromise; - await browser.close().catch((err) => { - console.error(`[check] kon de browser niet netjes sluiten: ${err && err.message}`); - }); + const browser = await browserPromise.catch(() => null); + if (browser) { + await browser.close().catch((err) => { + console.error(`[check] kon de browser niet netjes sluiten: ${err && err.message}`); + }); + } } } }